I have started doing more regular PR’s on my teams
Kedro [1] pipelines. I generally take a
two phase approach to the review in order to give the reviewee both quick and
detailed feedback.
What is Kedro [2]
initial scan (Phase1) # [3]
- passing ci
- Variable Names
- Antipatterns
- No commented out code
- Docsttrings generally make sense
Phase1 is typically a quick scan over the PR right within the PR window in my browser.
Passing CI # [4]
- flake8
- black
- isort
- interrogate
- pytest
- build
The very first thing that needs to happen is automated CI. We use things like
flake8, black, isort, interrogate to ensure that everyone follows generic style
guides like pep8. The project does a build within the PR, but no deploy.
Variable Names # [5]
I strugle really hard to not impose my own opinion into the PR at this point,
and sometimes really want to change a lot of variable names. Typically I make
sure they don’t grow longer than necessary, too short, misspelled, or
inc...